Skip to content

fix(search): make semantic failure recovery clear and retryable - #119

Merged
charan-rathore merged 3 commits into
mainfrom
fix/search-error-state-ui
Nov 14, 2026
Merged

charan-rathore merged 3 commits into
mainfrom
fix/search-error-state-ui

Conversation

@charan-rathore

Copy link
Copy Markdown
Owner

Changes

Validation

On rebased head 3b1661e, based on main caa1575:

  • TypeScript, ESLint and production build passed. ESLint reported one ignored-file warning for next-env.d.ts in the explicit-file local harness, no errors.
  • Four focused desktop/mobile browser tests passed: model failure, keyword continuity, hidden/revealed technical details, retry to ready, and disable-midflight flow.
  • Reviewed failure, expanded-details and retry-ready screenshots.
  • Only panels.tsx and the recovery browser test change. No ranking, worker, indexing or query-path changes. The core benchmark qualification from fix(search): recover from embedding failures and in-flight disable #118 applies to the unchanged search implementation; no new benchmark claim is made here.

The existing workspace-heading clipping and below-viewport expanded details are not fixed by this change. Long-query and typo accuracy work remains separate.

Adds the approved error-state 'Turn on semantic search' action under the
existing alert in panels.tsx, on top of the qualified functional tree
(64d0311). The functional retry path it invokes (enableSemantic after a
failure) is the one qualified there; this change is only the visible
action plus the e2e that exercises it: alert + keyword continuity,
retry visible, network restored, retry -> ready, alert cleared.
…approved UI)

On the qualified functional base (64d0311): the semantic error state now
shows the approved plain-English alert ('Semantic search isn't working
right now. Keyword search still works.'), keeps the 'Turn on semantic
search' retry action, and tucks the raw model error under an expandable
'Technical details' row. The e2e covers alert copy, tucked-then-revealed
details, keyword continuity, and the retry-to-ready path.
Absolute /downloads paths do not exist on CI runners; same portability
fix as the disable-midflight spec on the functional branch. Test-only.
@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
memo-rable Ready Ready Preview Nov 14, 2026 2:40pm UTC

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T14:40:53.001648Z 3b1661e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@charan-rathore
charan-rathore merged commit dcb3f10 into main Nov 14, 2026
6 checks passed

This branch was successfully deployed

1 active deployment
Preview — 3b1661eb Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant